Update to PyTorch 2.5.1 and Python 3.12 (And fix some things) - #33
Merged
Conversation
There is seemingly a bug with python 3.6 versions (actions/setup-python#544)
Update python-package-testing.yml to fix failing tests
Contributor
Author
|
There was a little eigenvalue piece within the code that was deprecated, fixed it so the package works with the latest PyTorch. |
RaameshB
changed the title
Contributor
Author
|
This should probably fix the random seed issues that were there earlier. Also, I've modified some of the tests, some need manual checking, which I will do later. They are commented out and have TODOs. |
Contributor
Author
|
Gradient descent works now, all I did was pass the ESN hidden states into a linear layer if the learning algorithm was set to 'grad' |
RaameshB
changed the title
Owner
|
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still working on fixing the actual tests in the repository, but this should work once that is done.