atuin: drop empty sync_address that broke settings load - #15
Merged
Conversation
Atuin parses sync_address as an absolute URL, so `sync_address = ""` fails deserialization of the entire settings file. `atuin init zsh` then emitted nothing while still exiting 0, silently leaving Ctrl+R unbound in every shell on both accounts. auto_sync = false already disables sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync_address = ""fromdotfiles/atuin/config.toml. Atuin parses that key as an absolute URL, so an empty string fails deserialization of the entire settings file.auto_sync = false(already present) is the real switch, and atuin does not sync at all unless you are logged in..ai/knowledge/modern-cli-tools.md, which showedsync_frequency = "0"rather than what the repo actually ships.Why
Every new shell on both accounts printed:
More than cosmetic:
.zshrcrunseval "$(atuin init zsh)". With settings broken,atuin init zshwrites the error to stderr, writes nothing to stdout, and still exits 0. The shell keeps working, so the failure is silent, but the atuin Ctrl+R binding is never installed. This restores history search.Both accounts were affected, since
install/bootstrap.shsymlinks this one file into each home. It was just more visible viasu -, which spawns a fresh login shell.Test plan
Verified against atuin 18.18.1 (Homebrew), reproduced before and confirmed after:
atuin init zshemits the zsh widget definitions on stdout with empty stderr (before: error only, nothing on stdout).atuin statusreturnsYou are not logged in to a sync server, the correct local-only result, proving settings deserialize.zsh -l -i -c 'bindkey | grep atuin'shows"^R" atuin-searchplus the up-arrow variants.No
install/bootstrap.shre-run needed: the deployed config is a symlink into the repo, so the fix takes effect on the next shell.