Skip to content

fix(i18n): actually use i18n ctrl_key consistently#2457

Open
serhalp wants to merge 1 commit intomainfrom
serhalp/use-i18n-ctrl-key
Open

fix(i18n): actually use i18n ctrl_key consistently#2457
serhalp wants to merge 1 commit intomainfrom
serhalp/use-i18n-ctrl-key

Conversation

@serhalp
Copy link
Copy Markdown
Member

@serhalp serhalp commented Apr 10, 2026

🔗 Linked issue

N/A

🧭 Context

The i18n key already exists, we just weren't using it everywhere.

📚 Description

Replace hardcoded Ctrl with translations.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 10, 2026 1:06pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 10, 2026 1:06pm
npmx-lunaria Ignored Ignored Apr 10, 2026 1:06pm

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/composables/usePlatformModifierKey.ts 75.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5a3a129b-785d-438d-a4db-9b10a6e1ee4b

📥 Commits

Reviewing files that changed from the base of the PR and between eb2e6bb and 66254e0.

📒 Files selected for processing (1)
  • app/composables/usePlatformModifierKey.ts

📝 Walkthrough

Walkthrough

This change introduces internationalization support for platform-specific modifier key labels in the usePlatformModifierKey composable. The modification replaces hardcoded string values for the Ctrl key with localised labels retrieved through the useI18n() composable. The primaryModifierKeyLabel and commandPaletteShortcutLabel computed values now dynamically construct their strings using the localised Ctrl key label for non-Apple platforms, whilst preserving the existing Apple-specific symbol behaviour.

Possibly related PRs

Suggested reviewers

  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset: it explains the intent to replace hardcoded 'Ctrl' with i18n translations, which directly matches the file changes shown in the raw summary.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch serhalp/use-i18n-ctrl-key

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@serhalp serhalp added the needs review This PR is waiting for a review from a maintainer label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review This PR is waiting for a review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant