Skip to content

fix: improve search input text contrast accessibility #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kartykp merged 2 commits into from
May 29, 2026
+18 −17
Merged

fix: improve search input text contrast accessibility #1974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc7a70b
fix: improve search input text contrast accessibility
kartykp May 29, 2026
ffd0786
style: format npm-stage docs table
kartykp May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions content/cli/v11/commands/npm-stage.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,14 @@ Before using `npm stage` commands, ensure the following requirements are met:

### 2FA Requirements by Subcommand

| Command | Requires 2FA | Notes |
| --- | --- | --- |
| `npm stage publish` | No | Designed for automated workflows; defers 2FA to approval |
| `npm stage list` | No | View staged packages |
| `npm stage view` | No | View staged package details |
| `npm stage approve` | Yes | Prompts for 2FA to publish the staged package |
| `npm stage reject` | Yes | Prompts for 2FA to permanently remove the staged package |
| `npm stage download` | No | Downloads the tarball for local inspection |
| Command | Requires 2FA | Notes |
| -------------------- | ------------ | -------------------------------------------------------- |
| `npm stage publish` | No | Designed for automated workflows; defers 2FA to approval |
| `npm stage list` | No | View staged packages |
| `npm stage view` | No | View staged package details |
| `npm stage approve` | Yes | Prompts for 2FA to publish the staged package |
| `npm stage reject` | Yes | Prompts for 2FA to permanently remove the staged package |
| `npm stage download` | No | Downloads the tarball for local inspection |

### Tag Behavior

Expand All @@ -96,12 +96,12 @@ The tag is an immutable property of the staged package. Once a package is staged

The key difference with staged publishing is that `npm stage publish` never requires a 2FA prompt, regardless of token type. This is what makes it suitable for automated workflows. The goal of `npm stage publish` is deferring proof-of-presence to a later point in time.

| Token Type | `npm stage publish` | `npm publish` |
| --- | --- | --- |
| GAT with bypass | Can stage | Can publish (if allowed by package publishing access) |
| GAT without bypass | Can stage | 2FA prompt (if allowed by package publishing access) |
| Session token | Can stage | 2FA prompt |
| Trust token (OIDC) | Can stage (if allowed) | Can publish (if allowed) |
| Token Type | `npm stage publish` | `npm publish` |
| ------------------ | ---------------------- | ----------------------------------------------------- |
| GAT with bypass | Can stage | Can publish (if allowed by package publishing access) |
| GAT without bypass | Can stage | 2FA prompt (if allowed by package publishing access) |
| Session token | Can stage | 2FA prompt |
| Trust token (OIDC) | Can stage (if allowed) | Can publish (if allowed) |

### Trust Relationship Permissions

Expand Down
7 changes: 4 additions & 3 deletions src/components/text-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@ const TextInput = styled(PrimerTextInput)`
*/
input {
font-size: 16px !important;
color: rgb(225, 228, 232) !important;
color: var(--fgColor-default, #1f2328) !important;
caret-color: var(--fgColor-default, #1f2328) !important;
}

input::placeholder {
color: rgb(225, 228, 232) !important;
opacity: 0.7;
color: var(--fgColor-muted, #57606a) !important;
opacity: 1;
}
`
export default TextInput
Loading