security(hooks): dead code cleanup + injection scanner hardening (ADR-116, ADR-121)#198
Merged
security(hooks): dead code cleanup + injection scanner hardening (ADR-116, ADR-121)#198
Conversation
…on scanning (ADR-116, ADR-121) ADR-116: Delete scripts/validate-agent-references.py (completely unreferenced) ADR-121: Injection scanner hardening - Extract shared injection patterns into hooks/lib/injection_patterns.py - Update pretool-prompt-injection-scanner.py to use shared library - Add posttool-bash-injection-scan.py for scanning file writes via Bash - Add whitelist entry length validation (min 8 chars) and load logging in pretool-dangerous-command-guard.py and pretool-unified-gate.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADR-116: Dead Code Cleanup
scripts/validate-agent-references.py(150 lines, zero references anywhere)ADR-121: Injection Scanner Hardening
hooks/lib/injection_patterns.py— shared injection pattern library extracted from scannerhooks/posttool-bash-injection-scan.py— PostToolUse hook scanning file writes via Bash (echo >, tee, cp)hooks/pretool-prompt-injection-scanner.py— now uses shared pattern libraryhooks/pretool-dangerous-command-guard.py— whitelist entry min length (8 chars) + load logginghooks/pretool-unified-gate.py— same whitelist hardeningAdvisory-only behavior preserved for all scanning hooks.
Test Plan