Skip to content
This repository was archived by the owner on Jun 21, 2025. It is now read-only.

Added new weapons to DamageType enum#224

Open
Lufou wants to merge 3 commits intonorthwood-studios:13.1from
Lufou:patch-1
Open

Added new weapons to DamageType enum#224
Lufou wants to merge 3 commits intonorthwood-studios:13.1from
Lufou:patch-1

Conversation

@Lufou
Copy link
Copy Markdown

@Lufou Lufou commented Sep 2, 2023

No description provided.

@Lufou Lufou changed the title Added FRMG0 to DamageType enum Added new weapons to DamageType enum Sep 2, 2023
Copy link
Copy Markdown
Member

@ced777ric ced777ric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for inserting the DamageType in the middle of the Enum?
This would cause issues with existing plugins by shifting the order of the Enum.

@Lufou Lufou requested a review from ced777ric September 2, 2023 17:16
Copy link
Copy Markdown

@SoNearSonar SoNearSonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants