ObjectBucket CRD schema missing claimRef fields

[naveenpaul1]

Describe the Problem

ObjectBucket CRD schema missing claimRef fields leads to data loss and bucket hijacking

Explain the changes

1. add 'x-kubernetes-preserve-unknown-fields" OB CRD

Issues: Fixed #xxx / Gap #xxx

1. https://redhat.atlassian.net/browse/DFBUGS-7972

Testing Instructions:

1. create OB and OBC and verify claimRef added with valid object

• Doc added/updated
• Tests added

Summary by CodeRabbit

• Bug Fixes
  • Updated ObjectBucket resource validation to allow nullable claim references.
  • Preserved unrecognized fields in the ObjectBucket resource schema for improved compatibility.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5498911e-9cf7-4761-ae4b-19b361816e0b

📥 Commits

Reviewing files that changed from the base of the PR and between 0e4d1ef and 5796c79.

📒 Files selected for processing (2)

• deploy/obc/objectbucket.io_objectbuckets_crd.yaml
• pkg/bundle/deploy.go

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The ObjectBucket CRD now permits nullable spec.claimRef values and preserves unknown fields. The bundled manifest reflects the schema update and uses a new checksum.

Changes

ObjectBucket schema synchronization

Layer / File(s)	Summary
Update claimRef schema and bundle deploy/obc/objectbucket.io_objectbuckets_crd.yaml, pkg/bundle/deploy.go	The CRD and bundled manifest allow null spec.claimRef values and preserve unknown fields. The exported manifest checksum is updated.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 5796c

This localized CRD update has no actionable merge-blocking risk remaining and is merge-ready after normal checks and review.

Suggested reviewers: dannyzaken

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: missing claimRef fields in the ObjectBucket CRD schema.
Description check	✅ Passed	The description includes all required sections, identifies the issue, explains the change, references the issue, and provides testing instructions.
Docstring Coverage	✅ Passed	Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nimrod-becker]

@dannyzaken @jackyalbo
I don't see a problem with deviating from lib-bucket-privisioner, but what do you think? should we open here or try and push to the original repo?

[romayalon]

@naveenpaul1 Wondering if we should try fix in https://github.com/kube-object-storage/lib-bucket-provisioner/blob/master/deploy/crds/objectbucket_v1alpha1_objectbucket_crd so we won't diverge, not sure if it's maintained, Nimrod asked Danny who is on the maintainers of lib-bucket-provisioner, let's see what he suggests

[dannyzaken]

@naveenpaul1 @nimrod-becker There is still some activity on the lib-bucket-provisioner repo (see here).
I suggest doing the fix there and then syncing the YAMLs to noobaa-operator.

[naveenpaul1]

Thank you @dannyzaken, Raised PR in lib-bucket-provisioner repo with same changes kube-object-storage/lib-bucket-provisioner#235