Improve bus route handling - #47
Conversation
|
@WardBrian would you mind taking a look here? these changes are large enough that i'd like to have some eyes on it! Given your contribs, i'd be happy to add you as a contributor as well if you'd like. |
|
I certainly can, though probably not until Tuesday. I’d also be happy to be added as a contributor :) |
No rush- whenever you have the time will be OK! |
WardBrian
left a comment
There was a problem hiding this comment.
This looks good to me, I think it makes a lot of sense to treat buses like this.
One concern I do have is if the MTA one day decides to split up the bus feed like they have the trains, then this API would be a lot more cumbersome to implement. But, I suppose there's no reason to plan for something that might never happen, and if it did it could always just be a major version bump.
Yeah i think that's something we'll deal with if it happens! |
fixes #46
resolve_urlfor the bus url. either the bus url orBUSwill be accepted.