Repository navigation
Fixes #383: robustness and portability fixes; WIMSR WLUP conventions for WIMSD-5 libraries - #384
Open
dlopezaldama wants to merge 2 commits into
Open
dlopezaldama wants to merge 2 commits into
dlopezaldama wants to merge 2 commits into
Conversation
dlopezaldama
force-pushed
the
feature_general_upd_dla
branch
from
October 29, 2026 15:35
adae662 to
01507d6
Compare
…ortability - wimsr: snu, abs1, ab0, xtr, sdp initialized. - leapr: terps returns for a negative index; no comma before the output list in two write statements. - endf tpidio: input unit rewound before the tape identification is read. - util openz: an open scratch unit is closed before it is reopened. - plotr/viewr mmax, maxaa and contour arrays, acepa nwscr increased. LANL tests 87/87; plot tapes of tests 06 and 12 updated (plotr thins the curves to about mmax points: finer curves with mmax=50000). - main: version number removed from the header comment. Fixes #383.
…ibraries Extension reported to and adopted by IAEA/NDS for the continuity of the WIMS-D Library Update Project: - discrete inelastic levels (MT51-91) added to the resonance scattering; - iverw=5 (wims-e/wimsd-5): scattering resonance integrals also converted (sigb*sigs/(sigb+siga)), and the data taken at the reference dilution sgref also when it is infinite; - ifis=2 when the resonance tables have no fission. The default iverw=4 output changes only through the inelastic levels inside the resonance groups (none in the LANL test 11 data). LANL tests: 87/87 (test 11 unchanged).
dlopezaldama
force-pushed
the
feature_general_upd_dla
branch
from
October 29, 2026 20:58
01507d6 to
5fec096
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fixes #383: robustness and portability fixes; WIMSR WLUP conventions for WIMSD-5 libraries
Base branch:
develop(rebased on NJOY2016.80, 51b1661).What is fixed
snu,abs1,ab0,xtrandsdpwere used without initialization.terpsread out of bounds for a negative index; twowritestatements had a comma before the outputlist (non-standard, rejected by some compilers).
mmax20000 → 50000,maxaa200000/500000 → 500000/5000000 (the viewr check usesmmaxinstead of a fixed 5000), viewr contour arrays 2000 → 10000; acepanwscr50000 → 250000.WIMSR: WIMS-D Library Update Project conventions (second commit)
This extension was reported to IAEA/NDS and implemented there for the continuity of the WIMS-D Library Update
Project (WLUP); it is needed to produce WIMSD-5 formatted libraries:
iverw=5 (WIMS-E/WIMSD-5): the scattering resonance integrals are converted like absorption and fission(σb·σs/(σb+σa)), and the data are taken at the reference dilution
sgrefalso when it is infinite;ifis=2 when the resonance tables have no fission.With the default
iverw=4 the output changes only where inelastic levels fall inside the resonance groups (not thecase in the LANL test 11 data).
Compared with the earlier version of this PR: the ACE reaction names of
acecmmoved to the ACER PR (#376), so thatthe two PRs do not touch the same file.
Tests
develop(2016.80, 51b1661); replaces the earlier 2016.78-based commit of this branch.and tests/12/referenceTape24 (resonance plot with 1233 more lines): plotr thins each curve to about
mmaxpoints,so with
mmax=50000 the curves are drawn with more points. No other tape changes.Release notes entry
Proposed text for the next release section of
ReleaseNotes.md(not added to the file in this branch, to avoid conflicts between the open PRs):