Skip to content

Fixes #383: robustness and portability fixes; WIMSR WLUP conventions for WIMSD-5 libraries - #384

Open
dlopezaldama wants to merge 2 commits into
developfrom
feature_general_upd_dla
Open

dlopezaldama wants to merge 2 commits into
developfrom
feature_general_upd_dla

Conversation

@dlopezaldama

@dlopezaldama dlopezaldama commented Aug 25, 2025 •

Copy link
Copy Markdown
Member

Title: Fixes #383: robustness and portability fixes; WIMSR WLUP conventions for WIMSD-5 libraries

Base branch: develop (rebased on NJOY2016.80, 51b1661).

What is fixed

  1. wimsr: snu, abs1, ab0, xtr and sdp were used without initialization.
  2. leapr: terps read out of bounds for a negative index; two write statements had a comma before the output
    list (non-standard, rejected by some compilers).
  3. endf (tpidio): the input unit is rewound before the tape identification (the first record) is read.
  4. util (openz): a scratch unit still open from a previous module is closed before it is opened again.
  5. Array sizes: plotr/viewr mmax 20000 → 50000, maxaa 200000/500000 → 500000/5000000 (the viewr check uses
    mmax instead of a fixed 5000), viewr contour arrays 2000 → 10000; acepa nwscr 50000 → 250000.
  6. main: the header comment no longer gives an old version number.

WIMSR: WIMS-D Library Update Project conventions (second commit)

This extension was reported to IAEA/NDS and implemented there for the continuity of the WIMS-D Library Update
Project (WLUP); it is needed to produce WIMSD-5 formatted libraries:

  • the discrete inelastic levels (MT51-91) are added to the resonance scattering;
  • iverw=5 (WIMS-E/WIMSD-5): the scattering resonance integrals are converted like absorption and fission
    (σb·σs/(σb+σa)), and the data are taken at the reference dilution sgref also when it is infinite;
  • ifis=2 when the resonance tables have no fission.
    With the default iverw=4 the output changes only where inelastic levels fall inside the resonance groups (not the
    case in the LANL test 11 data).

Compared with the earlier version of this PR: the ACE reaction names of acecm moved to the ACER PR (#376), so that
the two PRs do not touch the same file.

Tests

  • Rebased on develop (2016.80, 51b1661); replaces the earlier 2016.78-based commit of this branch.
  • LANL test suite: 87/87 pass (test 11, WIMSR, unchanged). Reference tapes updated: the PostScript plots tests/06/referenceTape32 (2 points added)
    and tests/12/referenceTape24 (resonance plot with 1233 more lines): plotr thins each curve to about mmax points,
    so with mmax=50000 the curves are drawn with more points. No other tape changes.

Release notes entry

Proposed text for the next release section of ReleaseNotes.md (not added to the file in this branch, to avoid conflicts between the open PRs):

  • WIMSR follows the conventions of the IAEA WIMS-D Library Update Project for WIMSD-5 formatted libraries (inelastic levels in the resonance scattering; iverw=5 scattering resonance integrals and reference dilution; ifis=2 without fission in the resonance tables).
  • Uninitialized arrays in WIMSR and an out-of-bounds read in LEAPR were corrected; a few non-standard constructs were changed for portability (LEAPR write statements); scratch units are closed before being reopened; array sizes were increased in PLOTR, VIEWR and ACEPA (issue general updates for modules: leapr,endf,util,main,plotr,viewr,acecm,wimsr #383).

@dlopezaldama
dlopezaldama force-pushed the feature_general_upd_dla branch from adae662 to 01507d6 Compare October 29, 2026 15:35
@dlopezaldama
dlopezaldama changed the base branch from main to develop October 29, 2026 15:36
@dlopezaldama dlopezaldama changed the title Fixes #383: Implemented required updates to enhance code robustness, … Fixes #383: robustness and portability fixes; WIMSR WLUP conventions for WIMSD-5 libraries Oct 29, 2026
…ortability

- wimsr: snu, abs1, ab0, xtr, sdp initialized.
- leapr: terps returns for a negative index; no comma before the output
  list in two write statements.
- endf tpidio: input unit rewound before the tape identification is read.
- util openz: an open scratch unit is closed before it is reopened.
- plotr/viewr mmax, maxaa and contour arrays, acepa nwscr increased.

LANL tests 87/87; plot tapes of tests 06 and 12 updated (plotr thins
the curves to about mmax points: finer curves with mmax=50000).
- main: version number removed from the header comment.

Fixes #383.
…ibraries

Extension reported to and adopted by IAEA/NDS for the continuity of the
WIMS-D Library Update Project:
- discrete inelastic levels (MT51-91) added to the resonance scattering;
- iverw=5 (wims-e/wimsd-5): scattering resonance integrals also
  converted (sigb*sigs/(sigb+siga)), and the data taken at the
  reference dilution sgref also when it is infinite;
- ifis=2 when the resonance tables have no fission.
The default iverw=4 output changes only through the inelastic levels
inside the resonance groups (none in the LANL test 11 data).

LANL tests: 87/87 (test 11 unchanged).
@dlopezaldama
dlopezaldama force-pushed the feature_general_upd_dla branch from 01507d6 to 5fec096 Compare October 29, 2026 20:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant