Repository navigation
Fixes #377: GROUPR partial fission in residual production, sqrt(E) smoothing conditions, storage checks - #379
Open
dlopezaldama wants to merge 1 commit into
Open
dlopezaldama wants to merge 1 commit into
dlopezaldama wants to merge 1 commit into
Conversation
dlopezaldama
force-pushed
the
feature_groupr_dla
branch
from
October 29, 2026 14:30
56e0a13 to
4e03250
Compare
…ditions, storage checks - MF26/36 heavy-residual production: fission was excluded only for MT18; MT19, 20, 21 and 38 are now excluded as well (in the input check, conver and the a>4 production list). - sqrt(E) extension of the low-energy neutron spectra (ismooth, MF6 LAW=1): applied only under the conditions already used by ACER (acelf6) in 2016.80: no discrete lines and first outgoing energy equal to zero; lin-lin tables also need more than 3 points. Before, only LEP and ZAP were checked, so discrete lines were smoothed and the first point of spectra not starting at zero was overwritten. - getsed: checks of the tmp storage; nwscr 10000 -> 20000, ncmax 1000 -> 7000, ntmp 10000 -> 20000; scr deallocated at the end of groupr and conver. LANL tests: 87/87 pass with the existing reference tapes. Fixes #377.
dlopezaldama
force-pushed
the
feature_groupr_dla
branch
from
October 29, 2026 20:44
4e03250 to
9751efb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fixes #377: GROUPR partial fission in residual production, sqrt(E) smoothing conditions, storage checks
Base branch:
develop(rebased on NJOY2016.80, 51b1661).What is fixed
residual-production lists only for MT18; MT19, 20, 21 and 38 are now excluded as well: in the input check
(a message is printed and the request skipped), in
converand in the a>4 production list.ismooth, MF6 LAW=1). The smoothing is applied onlyunder the conditions that ACER (
acelf6) already uses in 2016.80: no discrete lines and first outgoing energyequal to zero; lin-lin tables also need more than 3 points. Before, GROUPR checked only LEP and ZAP, so
discrete lines were smoothed and the first point of spectra not starting at zero was overwritten; GROUPR and
ACER are now consistent.
getsedchecks the size of thetmpstorage;nwscr10000 → 20000,ncmax1000 → 7000,ntmp10000 → 20000;scris deallocated at the end ofgrouprandconver.Tests
develop(2016.80, 51b1661); replaces the earlier 2016.78-based commit of this branch (whichconflicted with the 2016.79/.80 GROUPR changes).
Release notes entry
Proposed text for the next release section of
ReleaseNotes.md(not added to the file in this branch, to avoid conflicts between the open PRs):