Skip to content

FIX: Validate required PET timing metadata when combining runs#336

Merged
mnoergaard merged 3 commits into
mainfrom
fix_combine_runs_time
Jul 16, 2026
Merged

FIX: Validate required PET timing metadata when combining runs#336
mnoergaard merged 3 commits into
mainfrom
fix_combine_runs_time

Conversation

@mnoergaard

Copy link
Copy Markdown
Collaborator

This follow-up hardens PET run combination for dual-time-window and other multi-run acquisitions.

  1. Require valid TimeZero and finite numeric ScanStart, InjectionStart, and ImageDecayCorrectionTime for every run.
  2. Reject runs whose frame timing begins before ScanStart.
  3. Keep ScanStart as an internal consistency check rather than a cross-run alignment anchor.
  4. Preserve the existing TimeZero/InjectionStart alignment and decay-rescaling calculations.
  5. Add coverage for scan-relative and injection-relative dual-window timing.
  6. Update the run-combination documentation to describe the required metadata and validation behavior.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.19%. Comparing base (1617443) to head (f2ec05a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   87.14%   87.19%   +0.04%     
==========================================
  Files          89       89              
  Lines       10552    10603      +51     
  Branches     1129     1136       +7     
==========================================
+ Hits         9196     9245      +49     
- Misses       1124     1125       +1     
- Partials      232      233       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mnoergaard
mnoergaard merged commit 37c5266 into main Jul 16, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant