Skip to content

feat: disable feature flagging#192

Merged
nikilok merged 2 commits into
mainfrom
feat/disable-feature-flagging
Jun 26, 2026
Merged

feat: disable feature flagging#192
nikilok merged 2 commits into
mainfrom
feat/disable-feature-flagging

Conversation

@nikilok

@nikilok nikilok commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Simplified company pages to load only the data needed, reducing unnecessary flag-related processing.
    • The GOV.UK link branding now appears consistently on company detail pages.

@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
learn-tanstack-start Ready Ready Preview, Comment Jun 26, 2026 1:47pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9e48ee85-55a2-403f-93b7-a128de7c4d0d

📥 Commits

Reviewing files that changed from the base of the PR and between 9738eaf and 3176d0c.

📒 Files selected for processing (3)
  • apps/web/src/api/flags.ts
  • apps/web/src/flags.server.ts
  • apps/web/src/routes/company.$id.$slug.tsx
💤 Files with no reviewable changes (1)
  • apps/web/src/api/flags.ts

📝 Walkthrough

Walkthrough

The PR removes the flag-state query path, updates the server flag registry to an empty typed map, and changes the company detail route to stop loading or using flagState. The GOV.UK link now always renders GovUkLogo.

Changes

Flag state removal

Layer / File(s) Summary
Flag registry shape
apps/web/src/flags.server.ts
FlagValue is added and the exported flags registry becomes an empty Record<string, FlagSpec<FlagValue>>; the hardcoded govukBranded export is removed.
Company route without flagState
apps/web/src/routes/company.$id.$slug.tsx
The route stops importing and loading flagStateQueryOptions, returns only sponsor and profile, removes flagState from loader data usage, and always uses GovUkLogo for the GOV.UK link.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I hopped through flags, then set them free,
No more flagState for this tree.
My ears go up, my whiskers sway,
GovUK logo leads the way.
A tidy hop, a lighter load —
*thump* *thump* along the route I strode.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: feature flagging was removed or disabled across the app.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/disable-feature-flagging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nikilok nikilok merged commit 8fd4449 into main Jun 26, 2026
5 checks passed
@nikilok nikilok deleted the feat/disable-feature-flagging branch June 26, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant