getchar on non-terminal exit#22
Open
nihui wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses graceful exit behavior by introducing a prompt for user key input when not running in an interactive terminal and modifying the command-line argument handling to allow running with no arguments.
- Added cross-platform terminal detection macros and corresponding includes
- Updated command-line argument validation to support both 0 and 1 device id argument
- Added a prompt on non-terminal exit using getchar()
| if (argc != 2) | ||
| if (argc != 1 && argc != 2) | ||
| { | ||
| fprintf(stderr, "Usage: %s [device_id]\n", argv[0]); |
There was a problem hiding this comment.
The usage message 'Usage: %s [device_id]' does not clearly convey that running the program with no arguments is valid. Consider updating the message to indicate that the device_id parameter is optional when no argument is provided.
Suggested change
| fprintf(stderr, "Usage: %s [device_id]\n", argv[0]); | |
| fprintf(stderr, "Usage: %s [device_id] (device_id is optional; defaults to the first available device if not provided)\n", argv[0]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.