Skip to content

getchar on non-terminal exit#22

Open
nihui wants to merge 4 commits into
masterfrom
auto-device-id
Open

getchar on non-terminal exit#22
nihui wants to merge 4 commits into
masterfrom
auto-device-id

Conversation

@nihui

@nihui nihui commented May 27, 2025

Copy link
Copy Markdown
Owner

No description provided.

@nihui nihui requested a review from Copilot May 27, 2025 15:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses graceful exit behavior by introducing a prompt for user key input when not running in an interactive terminal and modifying the command-line argument handling to allow running with no arguments.

  • Added cross-platform terminal detection macros and corresponding includes
  • Updated command-line argument validation to support both 0 and 1 device id argument
  • Added a prompt on non-terminal exit using getchar()

Comment thread vkpeak.cpp
if (argc != 2)
if (argc != 1 && argc != 2)
{
fprintf(stderr, "Usage: %s [device_id]\n", argv[0]);

Copilot AI May 27, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage message 'Usage: %s [device_id]' does not clearly convey that running the program with no arguments is valid. Consider updating the message to indicate that the device_id parameter is optional when no argument is provided.

Suggested change
fprintf(stderr, "Usage: %s [device_id]\n", argv[0]);
fprintf(stderr, "Usage: %s [device_id] (device_id is optional; defaults to the first available device if not provided)\n", argv[0]);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants