Repository navigation
Add taxonomytree_test fixtures for custom/taxonomytree module tests - #2274
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014eSqkuYZXfNiWy87y3srup
Joon-Klaps
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Needed by nf-core/modules#12977 (custom/taxonomytree module + taxonomy2phylogeny subworkflow).
README.mdREADME.mdis still up-to-dateDescription
Two small fixtures for
custom/taxonomytreeandtaxonomy2phylogenytests innf-core/modules#12977:
data/generic/tax/taxonomytree_test.tax: 6 samples' taxonomy strings.data/generic/fasta/taxonomytree_test.fasta: matching 6 synthetic 61bp DNA sequences withreal phylogenetic signal (three shared-mutation pairs).
6 taxa, not 4: a 4-taxon taxonomy-derived guide tree is always fully resolved (any grouping on
4 leaves already needs the one internal split an unrooted 4-taxon tree has), which
raxml-ng --tree-constraintcorrectly rejects as "not a real constraint" -- confirmed byhitting that exact rejection with an earlier 4-taxon draft. 6 taxa (one resolved pair, a 3-way
polytomy, and a second resolved pair under a different kingdom) gives a genuine, still-unresolved
constraint, needed to test the guide-tree-as-constraint wiring for real.
🤖 Generated with Claude Code
https://claude.ai/code/session_014eSqkuYZXfNiWy87y3srup