Release PR - #115
Merged
Merged
Release PR#115
Conversation
sguizard
requested changes
Sep 17, 2026
sguizard
left a comment
sguizard
left a comment
There was a problem hiding this comment.
Congratulation for the pipeline.
Some corrections (in comments) need to be applied before approving the PR.
Collaborator
Author
|
@sguizard, thank you very much for the review! I'll incorporate the feedback. |
erikrikarddaniel
left a comment
erikrikarddaniel
left a comment
Member
There was a problem hiding this comment.
I left reviewing to Claude since I don't know the field. Since it found real bugs, I'm not approving yet. Ping me when you've addressed the below. Here's the verdict, plus a few inline comments:
Two things break real use and are cheap to fix. Details are in the inline comments.
- Relative paths are rejected. Every example in docs/usage.md uses relative paths. But rna_matrix/hto_matrix in the samplesheet, and --demultiplexing_result, --cell_genotype, --vireo_filtered_variants, --gt_donors and --common_variants, reach a path input as plain strings. Nextflow only accepts absolute strings there. The user sees only Execution aborted due to an unexpected error; the real cause (Not a valid path value: 'hto.tar.gz') is only in .nextflow.log. Reproduced with -profile test_hashing,docker -stub and a local samplesheet, and with -profile test_donor_match,docker -stub and local files for the four params.
- -stub fails in donor_match mode. The FIND_VARIANTS stub writes file names that do not match its output globs: Missing output file(s) *_all_representative_variants.csv. Reproduced with -profile test_donor_match,docker -stub.
Collaborator
Author
|
@sguizard and @erikrikarddaniel, thank you very much! I incorporated all your feedback. Again, I learned a lot, using MultiQC, reviewing with Claude,... Ready for the first release? 🚀 |
sguizard
approved these changes
Sep 28, 2026
|
Approved! 🍾🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First release of nf-core/hadge! 🚀