Tagging#5
Open
ColeT wants to merge 3 commits into
Open
Conversation
some minor code cleanup that removes warnings from npm start.
adding tagging to my links page. only front end code.
manifest now saves tags, my links now displays tags
neyer
approved these changes
Jun 15, 2022
neyer
left a comment
neyer
left a comment
Owner
There was a problem hiding this comment.
This is great overall. You might consider adding something on the 'feed' page to render the tags added by users; you could add on a count showing how many other users applied that tag.
| import { selectManifest , addLinkByUrl, removeLink } from './state/manifestSlice.js' | ||
| import { selectCredentials } from './state/credentialsSlice.js' | ||
| import { useSelector, useDispatch} from 'react-redux' | ||
| const numberOfTags = 4; |
Owner
There was a problem hiding this comment.
This is more like numberOfTagsOnInputForm, yes? We can limit the UI to just showing 4 tag fields for right now if that's easier, but one goal would be to let people add arbitrary numbers of tags here.
| title: linkDesc.title, | ||
| url: linkDesc.url, | ||
| timestamp_ms: new Date().getTime(), | ||
| tags: linkAndCreds.tags |
Owner
There was a problem hiding this comment.
We should change linkAndCreds to be more accurate, since now we are taking in the link, the credentials, and a list of tags to apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding front end support for adding tags when adze-ing a link. Changed how existing links display to make the remove option more clear, and gave them a box to make the separation between different links more clear. Differentiated the link from the link title. Adding placeholder examples of info tags.