Repository navigation
[stack] feat(mail): add sender, note, details and buttons blocks to email template - #65193
Merged
Merged
Conversation
skjnldsv
added
enhancement
3. to review
skjnldsv
requested review from
CarlSchwan,
come-nc,
leftybournes and
provokateurin
and removed request for
a team
October 6, 2026 14:49
5 of 8 tasks
skjnldsv
added
enhancement
3. to review
skjnldsv
added this pull request to stack #65196
October 6, 2026 14:56
skjnldsv
changed the title
skjnldsv
force-pushed
the
feature/mail-template-blocks
branch
from
October 6, 2026 14:57
0800355 to
d0723ad
Compare
CarlSchwan
approved these changes
Oct 6, 2026
skjnldsv
force-pushed
the
feature/mail-template-blocks
branch
from
October 6, 2026 16:50
d0723ad to
9947f6a
Compare
skjnldsv
force-pushed
the
feature/mail-template-blocks
branch
from
October 6, 2026 18:14
9947f6a to
f412a28
Compare
skjnldsv
removed this pull request from stack #65196
October 6, 2026 18:15
…plate Adds addBodySender, addBodyNote, addBodyDetails and addBodyButtons to IEMailTemplate, with the EMailDetails and EMailDetailsRow value classes for the details card. All values are escaped by the template, each block also renders a plain text version. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
feature/mail-template-blocks
branch
from
October 6, 2026 18:23
f412a28 to
9e39985
Compare
skjnldsv
added this pull request to stack #65223
October 6, 2026 18:34
Contributor
|
Hi @skjnldsv Since we are redoing the email templates, would it make sense to extract them in to external files? Instead of hard coding them in PHP, this is messy. If they where external files in the themes folder they could be easily customized on a per instance or per group level. Yes, I know this might be out of scope, just an idea |
Member
Author
yes, this is in my todo; After this whole stack is merged, I'll focus on doing a cleaner refactor where each block has its own php file. Should be cleaner, easier to test and more flexible :) |
SebastianKrupinski
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Share, calendar and Talk mails all show a person and an item, and right now the only tool for that is list items with tiny icons. This adds four blocks to the email template. The restyle comes in #65194, and #65195, #65220, #65221 and #65222 move the mails to the new blocks.
addBodySender($name, $subline)addBodyNote($text, $label, $type)addBodyDetails(EMailDetails)addBodyButtons($buttons, $label)None of them take HTML: everything is escaped and each block writes its own plain text version.
All four blocks in the current look (the test fixture), before the restyle:
TODO
Checklist
AI (if applicable)
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.