Skip to content

chore: drop legacy WhatsNew #57583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Jan 21, 2026
Merged

chore: drop legacy WhatsNew #57583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
428e762
chore: drop legacy `WhatsNew`
susnux Jan 15, 2026
0e75043
chore: compile assets
susnux Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions apps/updatenotification/lib/UpdateChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,13 @@
*/
namespace OCA\UpdateNotification;

use OC\Updater\ChangesCheck;
use OC\Updater\VersionCheck;
use OCP\AppFramework\Services\IInitialState;

class UpdateChecker {

public function __construct(
private VersionCheck $updater,
private ChangesCheck $changesCheck,
private IInitialState $initialState,
) {
}
Expand All @@ -41,13 +39,6 @@ public function getUpdateState(): array {
if (strpos($data['url'], 'https://') === 0) {
$result['downloadLink'] = $data['url'];
}
if (strpos($data['changes'], 'https://') === 0) {
try {
$result['changes'] = $this->changesCheck->check($data['changes'], $data['version']);
} catch (\Exception $e) {
// no info, not a problem
}
}

return $result;
}
Expand Down
11 changes: 0 additions & 11 deletions apps/updatenotification/tests/UpdateCheckerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
*/
namespace OCA\UpdateNotification\Tests;

use OC\Updater\ChangesCheck;
use OC\Updater\VersionCheck;
use OCA\UpdateNotification\UpdateChecker;
use OCP\AppFramework\Services\IInitialState;
Expand All @@ -17,7 +16,6 @@

class UpdateCheckerTest extends TestCase {

private ChangesCheck&MockObject $changesChecker;
private VersionCheck&MockObject $updater;
private IInitialState&MockObject $initialState;
private UpdateChecker $updateChecker;
Expand All @@ -26,11 +24,9 @@ protected function setUp(): void {
parent::setUp();

$this->updater = $this->createMock(VersionCheck::class);
$this->changesChecker = $this->createMock(ChangesCheck::class);
$this->initialState = $this->createMock(IInitialState::class);
$this->updateChecker = new UpdateChecker(
$this->updater,
$this->changesChecker,
$this->initialState,
);
}
Expand Down Expand Up @@ -85,15 +81,10 @@ public function testGetUpdateStateWithUpdateAndValidLink(): void {
'versionstring' => 'Nextcloud 1.2.3',
'web' => 'https://docs.nextcloud.com/myUrl',
'url' => 'https://downloads.nextcloud.org/server',
'changes' => 'https://updates.nextcloud.com/changelog_server/?version=123.0.0',
'autoupdater' => '1',
'eol' => '0',
]);

$this->changesChecker->expects($this->once())
->method('check')
->willReturn($changes);

$expected = [
'updateAvailable' => true,
'updateVersion' => '1.2.3',
Expand All @@ -102,7 +93,6 @@ public function testGetUpdateStateWithUpdateAndValidLink(): void {
'versionIsEol' => false,
'updateLink' => 'https://docs.nextcloud.com/myUrl',
'downloadLink' => 'https://downloads.nextcloud.org/server',
'changes' => $changes,
];
$this->assertSame($expected, $this->updateChecker->getUpdateState());
}
Expand All @@ -126,7 +116,6 @@ public function testSetInitialState(): void {
'versionstring' => 'Nextcloud 1.2.3',
'web' => 'https://docs.nextcloud.com/myUrl',
'url' => 'https://downloads.nextcloud.org/server',
'changes' => 'https://updates.nextcloud.com/changelog_server/?version=123.0.0',
'autoupdater' => '1',
'eol' => '0',
]);
Expand Down
6 changes: 0 additions & 6 deletions build/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3215,12 +3215,6 @@
)]]></code>
</DeprecatedMethod>
</file>
<file src="core/Controller/WhatsNewController.php">
<DeprecatedMethod>
<code><![CDATA[getUserValue]]></code>
<code><![CDATA[setUserValue]]></code>
</DeprecatedMethod>
</file>
<file src="core/Middleware/TwoFactorMiddleware.php">
<DeprecatedInterface>
<code><![CDATA[private]]></code>
Expand Down
104 changes: 0 additions & 104 deletions core/Controller/WhatsNewController.php
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions core/Listener/AddMissingIndicesListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,6 @@ public function handle(Event $event): void {
true
);

$event->addMissingIndex(
'whats_new',
'version',
['version'],
[],
true
);

$event->addMissingIndex(
'cards',
'cards_abiduri',
Expand Down
52 changes: 0 additions & 52 deletions core/Migrations/Version14000Date20180626223656.php
View file
Open in desktop

This file was deleted.

23 changes: 23 additions & 0 deletions core/Migrations/Version34000Date20260122120000.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?php

/**
* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

namespace OC\Core\Migrations;

use OCP\DB\ISchemaWrapper;
use OCP\Migration\IOutput;
use OCP\Migration\SimpleMigrationStep;

class Version34000Date20260122120000 extends SimpleMigrationStep {
public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
/** @var ISchemaWrapper $schema */
$schema = $schemaClosure();
if ($schema->hasTable('whats_new')) {
$schema->dropTable('whats_new');
}
return $schema;
}
}
Loading
Loading