Allow to redirect instead of IFrame for some setups#43
Merged
nickvergessen merged 1 commit intomasterfrom Jun 21, 2017
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
MariusBluem
approved these changes
Jun 21, 2017
|
Also please add an option to open in new tab! |
Member
Author
|
Sorry that is not possible, because of how the menu navigation is generated by the server. |
Closed
|
It is possible if it shares code with ownCloud @nickvergessen, I finished this recently for ownCloud and will be submitting a PR to nextcloud soon: owncloud-archive/apps#2221 It's a PR that adds a user configurable option for the link taget: '_blank', '_top', '_self' (new window/tab, replace current tab, open in iframe). |
Member
Author
|
Yeah well, our menu navigation is different from the owncloud one ;) |
|
Cool, didn't realize the code diverged that much from OC.
To get the final new window functionality, could we do something like:
window.open(external_url);
window.history.back();
|
This was referenced Nov 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #27
@MorrisJobke in case you want to review this