Repository navigation
ci: check go.php redirect targets against the master build - #15962
Merged
Merged
Conversation
admin-sso pointed to configuration_server/sso_configuration.html, which is not part of the docs. Point it to the OpenID Connect page, the only SSO page we have. The theming icons heading anchor is #icon-theming, not #theming-of-icons. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Every target must start with / (go.php appends it to the version path), the page must exist in the build and its anchor must be an id on the page. Runs in the link-check job, on master builds only, since go.php is only deployed from master. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
github-actions
Bot
added
the
github_actions
skjnldsv
enabled auto-merge
October 28, 2026 19:06
Contributor
📖 Documentation PreviewNo RST documentation pages changed in this PR. Last updated: Thu, 29 Oct 2026 01:45:08 GMT |
go.php replaces the second user_manual segment with the reader's language, and the staged build has no user_manual/index.html (the deploy adds it). Check those targets the same way, against en. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
marcelklehr
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
#15960 fixed a go.php target without a leading slash that 404'd. This adds a check to the master link-check job so it can't happen again: every target must start with
/, the page must exist in the build, and its anchor must be an id on that page.Running it against the current
server/latestfound two more broken redirects, fixed in the first commit:admin-theming-iconspointed to#theming-of-icons, the heading anchor is#icon-theming. Server links to it from the theming admin settings.admin-ssopointed toconfiguration_server/sso_configuration.html, which doesn't exist. I pointed it to the OpenID Connect page, the only SSO page we have. Happy to drop the key instead.The script has a small test in
build/tests/, run in the same step.✅ Checklist
codespellor similar and addressed any spelling issues👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.