Skip to content

Conversation

@grnd-alt
Copy link
Member

$share->setId requires a string as of this pr: nextcloud/server#57575

@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84286 was 83517 (+0.92%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@grnd-alt grnd-alt force-pushed the fix/deckshareprovider-share-id-as-string branch from 1d6df21 to efe377d Compare January 28, 2026 13:08
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84289 was 83517 (+0.92%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@grnd-alt grnd-alt merged commit 94f19b8 into main Jan 28, 2026
42 checks passed
@grnd-alt grnd-alt deleted the fix/deckshareprovider-share-id-as-string branch January 28, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants