Conversation
Zoey2936
requested review from
pabzm and
szaimen
and
a balanced review from Copilot
August 8, 2026 19:09
Signed-off-by: Zoey <zoey@z0ey.de>
Collaborator
Honestly, I'd favour Nextcloud Zip archive shipping the already compressed files. Can you please create a FR for this here? https://github.com/nextcloud/server/issues Thanks in advance! :) |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3. to review, feature component)AI (if applicable)
After making some size comparisons, the results speak for brotli, it is the smallest when compressing nextcloud and the support in browser is perfect since many many years. So zstd (a little bit bigger on the highest level compared to brotlis highest level and not supported in older browsers) and gzip (bad compression) are not needed.
But I must correct myself in one important point: integrity checks break...
I see two options how this could be fixed:
I think option 2 is the best