Improve the documentation describing usage of the manual-install stack - #8134
Draft
gggeek wants to merge 6 commits into
Draft
Improve the documentation describing usage of the manual-install stack#8134gggeek wants to merge 6 commits into
gggeek wants to merge 6 commits into
Conversation
szaimen
added
3. to review
Signed-off-by: Gaetano Giunta <giunta.gaetano@gmail.com>
…iles and more uniform spacing; make it work regardless of starting invocation dir and presence of yq Signed-off-by: Gaetano Giunta <giunta.gaetano@gmail.com>
Signed-off-by: Gaetano Giunta <giunta.gaetano@gmail.com>
gggeek
force-pushed
the
gg/improve-manual-install-docs-1
branch
from
May 18, 2026 16:01
6c25577 to
5703b7e
Compare
…ouple of lines above, trying to make it work, in update-yaml.sh Signed-off-by: Gaetano Giunta <giunta.gaetano@gmail.com>
Signed-off-by: Gaetano Giunta <giunta.gaetano@gmail.com>
Collaborator
|
Hi @gggeek thanks for the PR! Can you please fix SC? :) |
…ouple of lines above, trying to make it work, in update-yaml.sh, take two Signed-off-by: Gaetano Giunta <giunta.gaetano@gmail.com>
pabzm
requested changes
Jun 1, 2026
pabzm
left a comment
pabzm
left a comment
Member
There was a problem hiding this comment.
Thank you for the changes, I like them! Just two nitpicks, then I'd approve of this PR.
| sed -i 's|","protocol":"|/|g' /tmp/containers.json | ||
| sed -i 's|"ip_binding":":|"ip_binding":"|g' /tmp/containers.json | ||
| cat /tmp/containers.json | ||
| #cat /tmp/containers.json |
Member
There was a problem hiding this comment.
I agree that we don't need this line, but I'd rather like to see it removed than commented out.
| cat temp.conf >> sample.conf | ||
| rm todo.conf temp.conf enabled.conf | ||
| cat sample.conf | ||
| #cat sample.conf |
Member
There was a problem hiding this comment.
I agree that we don't need this line, but I'd rather like to see it removed than commented out.
szaimen
added
2. developing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a side note: what about capping the length of lines in .md files at, say, 120 characters?
I find them quite unwieldy to edit as they are now...