Repository navigation
fix: healthcheck probes HTTPS only when the config defines the HTTPS frontend - #142
Conversation
…frontend Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: 🟡 Moderate · up to
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
0c709391-b3e8-4c63-b784-6b76ba7ec45c
📒 Files selected for processing: 1
healthcheck.sh
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
healthcheck.shprobes the ExApps HTTPS port whenever/certs/cert.pemexists, but the HTTPS frontend exists only when the config in use defines it. HaRP then works but stays unhealthy in two cases:/certs/cert.pemis added after the first start and the container is restarted:start.shreuses the config it generated earlier, so HTTPS stays off while the healthcheck probes port 8781./haproxy.cfgwithout an HTTPS frontend runs with a/certs/cert.pempresent.Changes
healthcheck.shchecks the HTTPS frontend only when the config in use definesfrontend ex_apps_https, the frontendstart.shenables when it finds/certs/cert.pem.A config generated on the current start behaves as before.