Skip to content

fix: healthcheck probes HTTPS only when the config defines the HTTPS frontend - #142

Merged
oleksandr-nc merged 1 commit into
mainfrom
fix/healthcheck-https-from-config
Oct 21, 2026
Merged

oleksandr-nc merged 1 commit into
mainfrom
fix/healthcheck-https-from-config

Conversation

@oleksandr-nc

@oleksandr-nc oleksandr-nc commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

healthcheck.sh probes the ExApps HTTPS port whenever /certs/cert.pem exists, but the HTTPS frontend exists only when the config in use defines it. HaRP then works but stays unhealthy in two cases:

  • /certs/cert.pem is added after the first start and the container is restarted: start.sh reuses the config it generated earlier, so HTTPS stays off while the healthcheck probes port 8781.
  • A custom /haproxy.cfg without an HTTPS frontend runs with a /certs/cert.pem present.

Changes

  • healthcheck.sh checks the HTTPS frontend only when the config in use defines frontend ex_apps_https, the frontend start.sh enables when it finds /certs/cert.pem.

A config generated on the current start behaves as before.

…frontend

Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

📝 Walkthrough

The script checks the EXAPPS HTTP frontend unconditionally. It checks the EXAPPS HTTPS frontend when the active HAProxy configuration defines ex_apps_https. The documentation now describes this configuration-based condition.

Priority: ⬇️ Low

Merge Risk: 🟡 Moderate · up to 145cb

Custom HTTPS configurations using a different port can be marked unhealthy despite serving traffic. Align the probe with the configured bind before merging, unless deployments are required to provide a matching address override.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: HTTPS healthchecks now depend on the configured HTTPS frontend.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The pull request description directly explains the healthcheck.sh change and the cases where the HTTPS frontend is disabled despite /certs/cert.pem being present.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0c709391-b3e8-4c63-b784-6b76ba7ec45c
📥 Commits

Reviewing files that changed from the base of the PR and between 7c4dada and 145cb0d.

📒 Files selected for processing: 1
  • healthcheck.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread healthcheck.sh
@oleksandr-nc
oleksandr-nc merged commit ff2417c into main Oct 21, 2026
18 checks passed
@oleksandr-nc
oleksandr-nc deleted the fix/healthcheck-https-from-config branch October 21, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant