In using :video, removes the requirement that URL must start with https (in makeVideoHtml())#183
Open
cedricsam wants to merge 1 commit intonewsdev:masterfrom
Open
Conversation
…ttps * Could be useful for videos hosted at a relative URL or for URL rewriting (let's say you're on staging and want to point to a video on staging server; then switch to live seamlessly) * I could also see a case where the `.mp4` check could be removed but that seems like most people will support at least mp4 and can rewrite it if they're in an environment that allows JS
cedricsam
changed the title
:video, removes the requirement that URL must start with https:video, removes the requirement that URL must start with https (in makeVideoHtml())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(redoing #179 because i had to make a separate PR/suggestion!)
Could be useful for videos hosted at a relative URL or for URL rewriting (let's say you're on staging and want to point to a video on staging server; then switch to live seamlessly)
I could also see a case where the
.mp4check could be removed but that seems like most people will support at least mp4 and can rewrite it if they're in an environment that allows JS