Fix mingw build only (rtu_usb specific)#5
Merged
jimklimov merged 4 commits intonetworkupstools:rtu_usbfrom Jan 26, 2025
Merged
Conversation
Just cast from `ssize_t` to a more portable `long long int` type; here even a `short int` should be big enough for expected values. If a more diligent solution is needed in the future, see e.g. https://github.com/networkupstools/nut/blob/master/include/nut_stdint.h Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
…lled Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… the standard one; do return from method if that implementation fails Note that the primary "weird" use-case is about libusb backend; its _modbus_rtu_usb_select() ignores "rset" anyway, and talks to the libusb context. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated from PR #3 that also tries to fix tests and code, and may take more time to complete through all the questionable changes into production code (e.g. flushing or not upon reconnection attempts).
Another change set was extracted as #4
This subset of those changes focuses more strictly on passing builds without warnings, due to regressions allegedly due to NUT
rtu_usbbranch itself:rtu_usbbranch not as portable as they should be (printing of int types)clang-formatctx->s < 0case): after all, do return if we failselect()-- it is not the LIBC one, but the backend-defined one. So in this use-case, the rtu_usb backend does not even care about thefdsetand has its own ways to decide on success or failure of the communications attempt.