Skip to content

fix(transport): Send message and separator in one write call - #521

Open
jarrismwhite wants to merge 1 commit into
netsampler:mainfrom
jarrismwhite:race-patch
Open

fix(transport): Send message and separator in one write call#521
jarrismwhite wants to merge 1 commit into
netsampler:mainfrom
jarrismwhite:race-patch

Conversation

@jarrismwhite

@jarrismwhite jarrismwhite commented Jul 17, 2026

Copy link
Copy Markdown

With multiple workers, a second message can get written before the lineSeparator can, resulting in parsers counting on the separator to fail intermittently. It doesn't happen for every message, but it's enough to measure consistently.

Expected:

"{...}\n{...}\n{...}\n"

Observed:

"{...}\n{...}{...}\n\n"

It seems like this was introduced with #447 when data and lineSeparator were separated into two writes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant