chart: drop pidfile workaround; bump to 0.2.0#1
Merged
Conversation
Removes the pidfile initContainer + emptyDir + subPath mount that worked around netdisco-docker's read-only /home/netdisco. With netdisco/netdisco-docker#114 (chgrp 0 + chmod g=u on /home/netdisco) that workaround is no longer needed and was only ever a partial fix anyway: it covered netdisco-backend.pid but not netdisco-web.pid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
netdisco.pidfileInitContainerhelper and the correspondingemptyDir+subPathmount on/home/netdisco/netdisco-backend.pid.netdisco/netdisco-docker#114 adds
chgrp -R 0 /home/netdisco && chmod -R g=u /home/netdiscoto the base image, which lets any UID with supplementalgid 0(i.e. every OpenShift pod) write inside/home/netdisco. Once that lands and is published, the chart no longer needs any of the workaround. Issue described in #113Bumps chart version to
0.2.0Test plan
Validate Helm Chartworkflow passes (ct lint,helm template,kubeconform)Release Helm Chartworkflow onmainproducesnetdisco-0.2.0.tgzand updatesgh-pages