Closes #22657: escape exception message in render_widget before mark_safe#22658
Merged
Conversation
…safe str(e) was interpolated directly into the mark_safe-wrapped error HTML, allowing attacker-influenced exception text to inject markup into the dashboard. Fix: wrap the interpolated value with escape() so HTML special characters are rendered as literals. Add RenderWidgetTemplateTagTestCase covering both script-injection and angle-bracket cases to pin the escaping behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bctiemann
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #22657
Summary
render_widgetinextras/templatetags/dashboard.pycaught widget rendering exceptions and interpolatedstr(e)directly into amark_safe-wrapped HTML string. If the exception message contained HTML (e.g. from an attacker-influenced URL or external API response included in a widget), that markup would execute in the user's browser.Fix
Wrap the exception value with
escape()before interpolation:The two translated strings (
message1,message2) are static literals and require no escaping.Tests
RenderWidgetTemplateTagTestCaseinextras/tests/test_dashboard.py— two cases:<script>alert(1)</script>in the exception message →<script>in output, no raw<script>tag<bad>in the exception message →<bad>in output