Add description & comments extractor for Devices & VMs - #1561
Open
mawit wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#1133
New Behavior
Two extractors are added to provide descriptions and comments for devices and VMs in the inventory plugin.
...
Contrast to Current Behavior
Current behavior is/was that description and comments were missing in the inventory.
...
Discussion: Benefits and Drawbacks
With this PR implemented, it is no longer necessary to look up the descriptions and/or comments separately, as they are already fetched when fetching the devices and VMs. So there is no additional API request needed, which makes playbooks faster.
...
Changes to the Documentation
No changes are needed as the fields which are available in the inventory are currently not documented (for example serial).
...
Proposed Release Note Entry
Add description & comments to the inventory plugin.
...
Double Check
develbranch.