Enhance FSMApplication state handling in agent_session.py #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
keugenek
commented
May 16, 2025
keugenek
commented
- Introduce is_diff_state property to determine if the FSM is in a diff state.
- Update is_completed logic to include FSMState.COMPLETE.
- Modify completion event handling to account for cases with no diff.
- Introduce is_diff_state property to determine if the FSM is in a diff state. - Update is_completed logic to include FSMState.COMPLETE. - Modify completion event handling to account for cases with no diff.
- Remove is_diff_state property and simplify completion event logic. - Update conditions for sending completion events based on is_completed status.
Collaborator
|
Should we update |
- Introduced _template_diff_sent to track if the initial template diff has been sent. - Added _state_diff_hash to cache the last sent diff hash for each FSM state, preventing duplicate sends. - Updated logic in get_app_diff to skip sending unchanged diffs for the same FSM state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.