Repository navigation
Serve legacy CloudFront dashboard assets from the LMS - #392
Merged
Merged
Conversation
Stored logo and preview URLs still point at the Bahrain CloudFront host. The files are already in Google storage, and the theme config response now returns the serve route instead. Co-authored-by: Cursor <cursoragent@cursor.com>
AliAlfaifi
approved these changes
Sep 28, 2026
The coverage gate requires every branch, and the non-dict values path was never hit. Co-authored-by: Cursor <cursoragent@cursor.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudfront.net/fx_dashboard/<tenant>/config_files/<file>URLs toLMS_ROOT_URL/api/fx/assets/v1/serve/....Deploy
Production runs a pinned Open edX image from nassau. Merging this pull request does not change production until that image is rebuilt and the tag in nassau is updated.
Test plan
test_rewrite_legacy_cloudfront_asset_urlspassesd3ihhyw2bnk9f1.cloudfront.netMade with Cursor