Skip to content

chore: update 3.3.2 mainnet contract history, clean-up previous contract migrations#1914

Merged
gilcu3 merged 5 commits intomainfrom
1912-332-in-mainnet-contract-history
Feb 2, 2026
Merged

chore: update 3.3.2 mainnet contract history, clean-up previous contract migrations#1914
gilcu3 merged 5 commits intomainfrom
1912-332-in-mainnet-contract-history

Conversation

@gilcu3
Copy link
Copy Markdown
Contributor

@gilcu3 gilcu3 commented Jan 30, 2026

Closes #1912 and #1897

@gilcu3 gilcu3 linked an issue Jan 30, 2026 that may be closed by this pull request
3.3.2 in mainnet contract-history #1912
Closed
@gilcu3 gilcu3 force-pushed the 1912-332-in-mainnet-contract-history branch from 439c4ea to 2abc2ca Compare January 30, 2026 07:50
gilcu3
gilcu3 commented Jan 30, 2026
View reviewed changes
Comment thread crates/contract/src/lib.rs
pub mod utils;
pub mod v3_0_2_state;
pub mod v3_2_0_state;
pub mod v3_3_2_state;
Copy link
Copy Markdown
Contributor Author

@gilcu3 gilcu3 Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% if we were leaving the old states on purpose, but taking into account that our contract size is already near dangerous sizes, I opted for only leaving the necessary code there

Copy link
Copy Markdown
Contributor

@DSharifi DSharifi Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a window where 3_0_2 was on mainnet and 3_2_0 was on testnet.

We can and should delete both the previous state modules in this PR now that they are unused.

Copy link
Copy Markdown
Contributor Author

@gilcu3 gilcu3 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, I thought I had done so 🙃

@gilcu3 gilcu3 marked this pull request as ready for review January 30, 2026 08:01
@gilcu3 gilcu3 force-pushed the 1912-332-in-mainnet-contract-history branch from 2abc2ca to 1460b02 Compare January 30, 2026 16:41
DSharifi
DSharifi requested changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@DSharifi DSharifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Blocker:

  • Please delete the previous state modules v3_0_2_state.rs and v3_2_0_state.rs now that they are dead code

Comment thread crates/contract/src/lib.rs
pub mod utils;
pub mod v3_0_2_state;
pub mod v3_2_0_state;
pub mod v3_3_2_state;
Copy link
Copy Markdown
Contributor

@DSharifi DSharifi Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a window where 3_0_2 was on mainnet and 3_2_0 was on testnet.

We can and should delete both the previous state modules in this PR now that they are unused.

@gilcu3 gilcu3 force-pushed the 1912-332-in-mainnet-contract-history branch from 1460b02 to 12a20af Compare February 2, 2026 08:01
DSharifi
DSharifi previously approved these changes Feb 2, 2026
View reviewed changes
barakeinav1
barakeinav1 previously approved these changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@barakeinav1 barakeinav1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as a secondary reviewer.

@gilcu3 gilcu3 dismissed stale reviews from barakeinav1 and DSharifi via eae1a27 February 2, 2026 08:16
netrome
netrome approved these changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gilcu3 gilcu3 enabled auto-merge February 2, 2026 08:32
@gilcu3 gilcu3 added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit 0168571 Feb 2, 2026
8 checks passed
@gilcu3 gilcu3 deleted the 1912-332-in-mainnet-contract-history branch February 2, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@netrome netrome netrome approved these changes

@DSharifi DSharifi DSharifi approved these changes

@barakeinav1 barakeinav1 barakeinav1 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3.3.2 in mainnet contract-history

4 participants

@gilcu3 @netrome @DSharifi @barakeinav1