Corrected loops to keep the bottom row (W-Z) letters. Made operations functions return instead of print. - #1
Open
JohnHammond wants to merge 2 commits into
Open
JohnHammond wants to merge 2 commits into
JohnHammond wants to merge 2 commits into
Conversation
…s function return rather than print.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation of the Polybius square works great because it keeps the J letter. The current code did not seem to properly handle the bottom row, so I corrected that with a for loop to 5 instead of 5.
Additionally I made the encipher and decipher function return the full data rather than print it, so it
can be used in a more modular manner. Hope this helps!