Bump NVorbis version from 0.10.0 to 0.10.1#8
Closed
bert2 wants to merge 1 commit intonaudio:masterfrom
bert2:bugfix/bump-NVorbis-version
Closed
Bump NVorbis version from 0.10.0 to 0.10.1#8bert2 wants to merge 1 commit intonaudio:masterfrom bert2:bugfix/bump-NVorbis-version
bert2 wants to merge 1 commit intonaudio:masterfrom
bert2:bugfix/bump-NVorbis-version
Conversation
Author
|
Unfortunately bumping the version will not solve my problem. There seems to be another bug in NVorbis. I created a bug report there: NVorbis/NVorbis#6 |
Author
|
Closing this, because a bump makes more sense when NVorbis/NVorbis#6 is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the NVorbis reference to the latest patch version.
Since NAudio.Vorbis 1.2.0 I'm getting
IndexOutOfRangeExceptions from NVorbis through NAudio.Vorbis. I noticed that the latest NVorbis release has a newer patch version and includes a commit that fixes some index calculation.I'm hoping that the NVorbis fix will also resolve my problems, but I didn't confirm it.
You can see the exceptions I'm running into in a Dependabot PR that upgrades my NAudio.Vorbis reference. The build fails when running integration tests against an OGG file: