fix: Prevent buffers from being wasted on a paused wayland recorder #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it currently stands, a paused
WaylandVideoRecorderwill use up its allocated "buffers" by returning fromprocess()without queuing the buffers back. This makes it stop issuing calls toprocessentirely which makes the thread get stuck and unable to resume with a later call tostart().In
pipewire-rsthis is handled automatically when callingdequeue_buffer()since the returnedBufferautomatically handles this in itsDropimplementation.I assumed that the intended behaviour of start/stop is to pause/resume rather than fully disassemble and reassemble the recording stack on each call.
Refs: