Skip to content

Conversation

@4JX
Copy link
Contributor

@4JX 4JX commented Aug 31, 2025

As it currently stands, a paused WaylandVideoRecorder will use up its allocated "buffers" by returning from process() without queuing the buffers back. This makes it stop issuing calls to process entirely which makes the thread get stuck and unable to resume with a later call to start().

In pipewire-rs this is handled automatically when calling dequeue_buffer() since the returned Buffer automatically handles this in its Drop implementation.

I assumed that the intended behaviour of start/stop is to pause/resume rather than fully disassemble and reassemble the recording stack on each call.

Refs:

@nashaofu nashaofu merged commit af30a88 into nashaofu:master Sep 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants