Fix medaka not detecting samtools#550
Open
zwets wants to merge 1 commit into
Open
Conversation
This fixes issue nanoporetech#537 with the patch proposed by @vineeth-s in comments on that issue
aeiwz
reviewed
Jun 23, 2026
aeiwz
left a comment
There was a problem hiding this comment.
No actionable findings.
The change correctly handles invalid UTF-8 bytes in later samtools --version output while preserving first-line version parsing. A focused reproduction returns 1.13 successfully.
Notes:
- No regression test covers malformed version output.
- The same fix already landed on master in commit 019a2ab (019a2ab) on December 8, 2025.
- PR #550 is therefore obsolete and currently unmergeable; it should be closed.
- The reported failure mode is confirmed in issue #537 (#537 (comment)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #537 with the patch proposed by @vineeth-s in the comments on that issue