Skip to content

Fix medaka not detecting samtools#550

Open
zwets wants to merge 1 commit into
nanoporetech:masterfrom
zwets:fix-samtools-detection
Open

Fix medaka not detecting samtools#550
zwets wants to merge 1 commit into
nanoporetech:masterfrom
zwets:fix-samtools-detection

Conversation

@zwets

@zwets zwets commented Jan 18, 2025

Copy link
Copy Markdown

This fixes issue #537 with the patch proposed by @vineeth-s in the comments on that issue

This fixes issue nanoporetech#537 with the patch proposed by @vineeth-s in comments on that issue

@aeiwz aeiwz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable findings.
The change correctly handles invalid UTF-8 bytes in later samtools --version output while preserving first-line version parsing. A focused reproduction returns 1.13 successfully.

Notes:

  • No regression test covers malformed version output.
  • The same fix already landed on master in commit 019a2ab (019a2ab) on December 8, 2025.
  • PR #550 is therefore obsolete and currently unmergeable; it should be closed.
  • The reported failure mode is confirmed in issue #537 (#537 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants