Skip to content

fix DataFrame.applymap has been deprecated.#259

Open
mdclone-oa wants to merge 2 commits into
nalepae:masterfrom
mdclone-oa:master
Open

fix DataFrame.applymap has been deprecated.#259
mdclone-oa wants to merge 2 commits into
nalepae:masterfrom
mdclone-oa:master

Conversation

@mdclone-oa

Copy link
Copy Markdown

fix issue #258

/usr/local/lib/python3.12/site-packages/pandarallel/data_types/dataframe.py:69: FutureWarning: DataFrame.applymap has been deprecated. Use DataFrame.map instead.
return data.applymap(user_defined_function)

change applymap to map and tests

@codecov

codecov Bot commented Nov 21, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.37%. Comparing base (46fc0e5) to head (861d0d8).
⚠️ Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (46fc0e5) and HEAD (861d0d8). Click for more details.

HEAD has 57 uploads less than BASE
Flag BASE (46fc0e5) HEAD (861d0d8)
63 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   91.37%   86.37%   -5.00%     
==========================================
  Files          12       12              
  Lines         580      580              
==========================================
- Hits          530      501      -29     
- Misses         50       79      +29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdclone-oa mdclone-oa marked this pull request as draft November 21, 2023 14:30
@mdclone-oa mdclone-oa marked this pull request as ready for review November 21, 2023 14:44
@shermansiu

Copy link
Copy Markdown

Unless we're dropping support for Pandas versions < 2.1, I'm against this, especially since Pandas 2.1 was released relatively recently.

There's also no reason to change the minimum Python version to 3.9...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants