Conversation
I implemented the activity complete command that allows the user to mark and activity as completed.
Closed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the "Complete an Activity" command that allows users to mark activities as completed via the CLI. The implementation adds a new complete subcommand under the activity command group, providing functionality to mark activities as completed by their ID.
- Added a new
completecommand to the activity CLI subcommands - Implemented activity completion functionality with ID validation and database updates
- Added support for reading activity ID from both command arguments and stdin with timeout handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
internal/cli/execute.go |
Registers the new CompleteCommand with the activity command group |
internal/cli/activity/complete_command.go |
Implements the complete command with ID parsing, database updates, and stdin input handling |
🐳 Container Image BuiltYour PR container image has been built and published: Supported architectures: linux/amd64, linux/arm64 Usage: docker run --rm ghcr.io/nakedsoftware/time:pr-48 --help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented the activity complete command that allows the user to mark and activity as completed.
Closes #11