Skip to content

Conversation

@konstantintieber
Copy link
Contributor

@konstantintieber konstantintieber commented Dec 5, 2025

Summary

Fixes the error that's currently happening when trying to view the diff of a workflow that is newly created and to be pushed.

How to reproduce (before fix):

  • On an instance that's connected to a git repo
  • Create a new workflow
  • Save it
  • Click "Push" in the sidebar
  • Click on "Compare versions" on the newly created workflow

Before

When clicking "Compare versions":

Screenshot 2025-12-05 at 23 00 26

After

When clicking "Compare versions":

Screenshot 2025-12-05 at 23 00 05

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@konstantintieber konstantintieber changed the title Pay 4107 diff view doesnt open fix(core): Workflow diff preview errors out in push dialog for workflow that's newly created Dec 5, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

@codecov
Copy link

codecov bot commented Dec 5, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
15384 1 15383 0
View the top 1 failed test(s) by shortest run time
GET /workflow-history/:workflowId should include workflowPublishHistory records related to each history item
Stack Traces | 0.016s run time
Error: expect(received).toHaveLength(expected)

Expected length: 1
Received length: 2
Received array:  [{"createdAt": "2025-12-05T22:22:03.512Z", "event": "activated", "id": 1, "userId": null, "versionId": "3b48aa21-6671-48e0-89b9-3f2a1f0c052a", "workflowId": "ybl1Ftegzp2vpif2"}, {"createdAt": "2025-12-05T22:22:03.513Z", "event": "deactivated", "id": 2, "userId": null, "versionId": "3b48aa21-6671-48e0-89b9-3f2a1f0c052a", "workflowId": "ybl1Ftegzp2vpif2"}]
    at Object.<anonymous> (.../test/integration/workflow-history.api.test.ts:163:52)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@bundlemon
Copy link

bundlemon bot commented Dec 5, 2025

BundleMon

Unchanged files (2)
Status Path Size Limits
WASM Dependencies
tree-sitter-bash.wasm
181.26KB -
WASM Dependencies
tree-sitter.wasm
74.47KB -

No change in files bundle size

Groups updated (2)
Status Path Size Limits
**/*.js
11.43MB (+146.74KB +1.27%) -
**/*.css
233.39KB (+12.62KB +5.72%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 5, 2025
@blacksmith-sh
Copy link

blacksmith-sh bot commented Dec 5, 2025

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
GET /workflow-history/:workflowId/GET /workflow-history/
:workflowId should include workflowPublishHistory records related to each history item
View Logs

Fix in Cursor

@currents-bot
Copy link

currents-bot bot commented Dec 5, 2025

E2E Tests: n8n tests passed after 10m 56.2s

🟢 573 · 🔴 0 · ⚪️ 43 · 🟣 2

View Run Details

Run Details

  • Project: n8n

  • Groups: 2

  • Framework: Playwright

  • Run Status: Passed

  • Commit: 952e4b0

  • Spec files: 129

  • Overall tests: 616

  • Duration: 10m 56.2s

  • Parallelization: 9

Groups

GroupId Results Spec Files Progress
multi-main:ui:isolated 🟢 54 · 🔴 0 · ⚪️ 0 9 / 9
multi-main:ui 🟢 519 · 🔴 0 · ⚪️ 43 · 🟣 2 120 / 120


This message was posted automatically by currents.dev | Integration Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants