-
Notifications
You must be signed in to change notification settings - Fork 51.5k
chore(core): Implement identifiers for resolvers #22826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 11m 8s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 5 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/cli/src/modules/dynamic-credentials.ee/credential-resolvers/identifiers/oauth2-introspection-identifier.ts">
<violation number="1" location="packages/cli/src/modules/dynamic-credentials.ee/credential-resolvers/identifiers/oauth2-introspection-identifier.ts:179">
P2: RFC 6749 Section 2.3.1 requires URL-encoding client credentials before base64 encoding for HTTP Basic authentication. Special characters in `clientId` or `clientSecret` could cause authentication failures.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Summary
Implements OAuth2 token introspection (RFC 7662) for dynamic credential resolution. The implementation validates and extracts unique identifiers from access tokens using the OAuth2 introspection endpoint, with support for both
client_secret_basicandclient_secret_postauthentication methods. Includes intelligent caching with TTL bounds based on token expiration and comprehensive test coverage.Related Linear tickets, Github issues, and Community forum posts
closes https://linear.app/n8n/issue/PAY-4226/implement-oauth-token-introspection
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)