-
Notifications
You must be signed in to change notification settings - Fork 51.5k
feat: Add and update telemetry events #22762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ai-1759
Are you sure you want to change the base?
Conversation
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (1)
Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 9m 20.7s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 21 files
Prompt for AI agents (all 2 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/frontend/editor-ui/src/features/ai/assistant/builder.store.ts">
<violation number="1" location="packages/frontend/editor-ui/src/features/ai/assistant/builder.store.ts:873">
P2: The `isPlaceholderValue` function is inconsistent with the placeholder validation logic in `extractPlaceholderLabel`. It only checks for `PLACEHOLDER_PREFIX` but not `PLACEHOLDER_SUFFIX`, which could lead to false positives for malformed strings that start with the prefix but don't have the proper suffix.</violation>
</file>
<file name="packages/frontend/editor-ui/src/app/composables/useWorkflowSaving.ts">
<violation number="1" location="packages/frontend/editor-ui/src/app/composables/useWorkflowSaving.ts:226">
P2: The `consumeAiBuilderMadeEdits()` flag is consumed before the save API call completes. If the save fails and the user retries (e.g., on version conflict), the telemetry will incorrectly report `aiBuilderAssisted = false` since the flag was already reset on the first attempt. Consider capturing the value without consuming it until after successful save, or restoring the flag on error.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Summary
User saved workflowevent with new parametersnode_roletoManual node exec finishedRelated Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)