Skip to content

Conversation

@mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Dec 4, 2025

Summary

  • Add workflow_builder_journey to track journey of user using builder
  • Update User saved workflow event with new parameters
  • Add node_role to Manual node exec finished

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 4, 2025
@bundlemon
Copy link

bundlemon bot commented Dec 4, 2025

BundleMon

Unchanged files (2)
Status Path Size Limits
WASM Dependencies
tree-sitter-bash.wasm
181.26KB -
WASM Dependencies
tree-sitter.wasm
74.47KB -

No change in files bundle size

Groups updated (1)
Status Path Size Limits
**/*.js
11.42MB (+621B +0.01%) -
Unchanged groups (1)
Status Path Size Limits
**/*.css
233.4KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 91.16022% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tures/ndv/parameters/components/ParameterInput.vue 16.66% 10 Missing ⚠️
...ges/cli/src/events/relays/telemetry.event-relay.ts 62.50% 3 Missing ⚠️
packages/workflow/src/telemetry-helpers.ts 94.64% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@currents-bot
Copy link

currents-bot bot commented Dec 5, 2025

E2E Tests: n8n tests passed after 9m 20.7s

🟢 573 · 🔴 0 · ⚪️ 37 · 🟣 2

View Run Details

Run Details

  • Project: n8n

  • Groups: 2

  • Framework: Playwright

  • Run Status: Passed

  • Commit: 88e456a

  • Spec files: 122

  • Overall tests: 610

  • Duration: 9m 20.7s

  • Parallelization: 9

Groups

GroupId Results Spec Files Progress
multi-main:ui 🟢 519 · 🔴 0 · ⚪️ 37 · 🟣 2 114 / 114
multi-main:ui:isolated 🟢 54 · 🔴 0 · ⚪️ 0 8 / 8


This message was posted automatically by currents.dev | Integration Settings

@blacksmith-sh

This comment has been minimized.

@mutdmour mutdmour marked this pull request as ready for review December 5, 2025 13:28
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 21 files

Prompt for AI agents (all 2 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/frontend/editor-ui/src/features/ai/assistant/builder.store.ts">

<violation number="1" location="packages/frontend/editor-ui/src/features/ai/assistant/builder.store.ts:873">
P2: The `isPlaceholderValue` function is inconsistent with the placeholder validation logic in `extractPlaceholderLabel`. It only checks for `PLACEHOLDER_PREFIX` but not `PLACEHOLDER_SUFFIX`, which could lead to false positives for malformed strings that start with the prefix but don&#39;t have the proper suffix.</violation>
</file>

<file name="packages/frontend/editor-ui/src/app/composables/useWorkflowSaving.ts">

<violation number="1" location="packages/frontend/editor-ui/src/app/composables/useWorkflowSaving.ts:226">
P2: The `consumeAiBuilderMadeEdits()` flag is consumed before the save API call completes. If the save fails and the user retries (e.g., on version conflict), the telemetry will incorrectly report `aiBuilderAssisted = false` since the flag was already reset on the first attempt. Consider capturing the value without consuming it until after successful save, or restoring the flag on error.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

@blacksmith-sh

This comment has been minimized.

@mutdmour mutdmour requested review from a team and removed request for a team December 5, 2025 16:09
@mutdmour mutdmour requested a review from mike12345567 December 5, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants