fix: PAY-4106 - Make workers memory constraints more container aware #22698

geemanjs · 2025-12-03T19:36:37Z

Summary

Moves to use process.constrainedMemory instead of os.totalmem() for determinig total available memory. According to the docs since Node 22 it backs off to uv_get_constrained_memory in libuv which means it should lookup from cgroups when available.

⚠️ Worth noting that if no limit or constraint is set on the container we revert back to looking up the host value as this is the "theoretical max"

Also adds an accordion section with other memory stats in it to give a better picture.

Changes the free memory chart to a more useful Memory usage (%) one.

Will raise a follow up ticket for this PR as the workers details page has a mix of os/host, process and job information on it.

Related Linear tickets, Github issues, and Community forum

closes PAY-4106

Review / Merge checklist

PR title and summary are descriptive. (conventions)
Docs updated or follow-up ticket created.
Tests included.
PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported

bundlemon · 2025-12-03T19:43:01Z

BundleMon

Unchanged files (2)

Status	Path	Size	Limits
✅	WASM Dependencies _{tree-sitter-bash.wasm}	181.26KB	-
✅	WASM Dependencies _{tree-sitter.wasm}	74.47KB	-

No change in files bundle size

Groups updated (2)

Status	Path	Size	Limits
✅	*/.js	11.43MB (+146.88KB +1.27%)	-
✅	*/.css	233.54KB (+12.76KB +5.78%)	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

codecov · 2025-12-03T19:43:39Z

Codecov Report

❌ Patch coverage is 1.16279% with 85 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ion.ee/components/WorkerMemoryMonitorAccordion.vue	0.00%	52 Missing ⚠️
...hestration.ee/components/WorkerChartsAccordion.vue	0.00%	17 Missing ⚠️
...ettings/orchestration.ee/components/WorkerCard.vue	0.00%	8 Missing ⚠️
...s/settings/orchestration.ee/orchestration.utils.ts	0.00%	5 Missing ⚠️
...ckages/cli/src/scaling/worker-status.service.ee.ts	25.00%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

cubic-dev-ai

3 issues found across 7 files

Prompt for AI agents (all 3 issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/frontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerChartsAccordion.vue">

<violation number="1" location="packages/frontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerChartsAccordion.vue:88">
P1: Bug: CPU chart labels should be assigned from `newDataJobs.labels` (the newly built labels), not from `dataCPU.value.labels` (stale state). This will cause label synchronization issues between charts.</violation>

<violation number="2" location="packages/frontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerChartsAccordion.vue:96">
P1: Bug: Memory chart labels should be assigned from `newDataJobs.labels` (the newly built labels), not from `dataMemoryUsage.value.labels` (stale state). This will cause label synchronization issues between charts.</violation>
</file>

<file name="packages/frontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerCard.vue">

<violation number="1" location="packages/frontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerCard.vue:74">
P3: Unit notation &#39;Gb&#39; should be &#39;GB&#39;. &#39;Gb&#39; means gigabits (used for data transfer rates), while &#39;GB&#39; means gigabytes (used for memory/storage). The original code correctly used &#39;GB&#39;.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

cubic-dev-ai · 2025-12-03T19:45:55Z

...ontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerChartsAccordion.vue

+			const usedMem = totalMem - item.data.process.memory.available;
+
+			const usage = (usedMem / totalMem) * 100;
+			newDataMemoryUsage.labels = dataMemoryUsage.value.labels;


P1: Bug: Memory chart labels should be assigned from newDataJobs.labels (the newly built labels), not from dataMemoryUsage.value.labels (stale state). This will cause label synchronization issues between charts.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/frontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerChartsAccordion.vue, line 96: <comment>Bug: Memory chart labels should be assigned from `newDataJobs.labels` (the newly built labels), not from `dataMemoryUsage.value.labels` (stale state). This will cause label synchronization issues between charts.</comment> <file context> @@ -74,22 +74,31 @@ orchestrationStore.$onAction(({ name, store }) => { + const usedMem = totalMem - item.data.process.memory.available; + + const usage = (usedMem / totalMem) * 100; + newDataMemoryUsage.labels = dataMemoryUsage.value.labels; + newDataMemoryUsage.datasets[0].data.push(usage.toFixed(2)); }); </file context>

Suggested change

newDataMemoryUsage.labels = dataMemoryUsage.value.labels;

newDataMemoryUsage.labels = newDataJobs.labels;

✅ Addressed in d659c15

cubic-dev-ai · 2025-12-03T19:45:55Z

...ontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerChartsAccordion.vue

-			newDataMemory.datasets[0].data.push(maxMemory - memAsGb(item.data.freeMem));
-			newDataMemory.labels = newDataJobs.labels;
+
+			newDataCPU.labels = dataCPU.value.labels;


P1: Bug: CPU chart labels should be assigned from newDataJobs.labels (the newly built labels), not from dataCPU.value.labels (stale state). This will cause label synchronization issues between charts.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/frontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerChartsAccordion.vue, line 88: <comment>Bug: CPU chart labels should be assigned from `newDataJobs.labels` (the newly built labels), not from `dataCPU.value.labels` (stale state). This will cause label synchronization issues between charts.</comment> <file context> @@ -74,22 +74,31 @@ orchestrationStore.$onAction(({ name, store }) => { - newDataMemory.datasets[0].data.push(maxMemory - memAsGb(item.data.freeMem)); - newDataMemory.labels = newDataJobs.labels; + + newDataCPU.labels = dataCPU.value.labels; + const totalMem = item.data.isInContainer + ? item.data.process.memory.constraint </file context>

Suggested change

newDataCPU.labels = dataCPU.value.labels;

newDataCPU.labels = newDataJobs.labels;

✅ Addressed in d659c15

cubic-dev-ai · 2025-12-03T19:45:55Z

packages/frontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerCard.vue

-				Average Load: {{ averageWorkerLoadFromLoadsAsString(worker.loadAvg ?? [0]) }} | Free Memory:
-				{{ memAsGb(worker.freeMem).toFixed(2) }}GB / {{ memAsGb(worker.totalMem).toFixed(2) }}GB
+				Average Load: {{ averageWorkerLoadFromLoadsAsString(worker.loadAvg ?? [0]) }} | Free memory:
+				{{ memAsGb(worker.process.memory.available) }}Gb /


P3: Unit notation 'Gb' should be 'GB'. 'Gb' means gigabits (used for data transfer rates), while 'GB' means gigabytes (used for memory/storage). The original code correctly used 'GB'.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/frontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerCard.vue, line 74: <comment>Unit notation 'Gb' should be 'GB'. 'Gb' means gigabits (used for data transfer rates), while 'GB' means gigabytes (used for memory/storage). The original code correctly used 'GB'.</comment> <file context> @@ -69,8 +70,13 @@ onBeforeUnmount(() => { - Average Load: {{ averageWorkerLoadFromLoadsAsString(worker.loadAvg ?? [0]) }} | Free Memory: - {{ memAsGb(worker.freeMem).toFixed(2) }}GB / {{ memAsGb(worker.totalMem).toFixed(2) }}GB + Average Load: {{ averageWorkerLoadFromLoadsAsString(worker.loadAvg ?? [0]) }} | Free memory: + {{ memAsGb(worker.process.memory.available) }}Gb / + {{ + memAsGb( </file context>

Suggested change

{{ memAsGb(worker.process.memory.available) }}Gb /

{{ memAsGb(worker.process.memory.available) }}GB /

Fair point - updated

currents-bot · 2025-12-04T14:34:20Z

✅

E2E Tests: n8n tests passed after 8m 54.7s

🟢 572 · 🔴 0 · ⚪️ 37 · 🟣 3

View Run Details

Run Details

Project: n8n
Groups: 2
Framework: Playwright
Run Status: Passed
Commit: 68c8aab
Spec files: 117
Overall tests: 609
Duration: 8m 54.7s
Parallelization: 9

Groups

GroupId	Results	Spec Files Progress
multi-main:ui	🟢 518 · 🔴 0 · ⚪️ 37 · 🟣 3	109 / 109
multi-main:ui:isolated	🟢 54 · 🔴 0 · ⚪️ 0	8 / 8

This message was posted automatically by currents.dev | Integration Settings

...ontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerChartsAccordion.vue

konstantintieber · 2025-12-05T14:14:27Z

...ontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerChartsAccordion.vue

-const maxMemory = memAsGb(orchestrationStore.workers[props.workerId]?.totalMem) ?? 1;
 const optionsMemory: Partial<ChartOptions<'line'>> = optionsBase();
-if (optionsMemory.scales?.y) optionsMemory.scales.y.suggestedMax = maxMemory;
+if (optionsMemory.scales?.y) optionsMemory.scales.y.suggestedMax = 100;


Where does this 100 value come from?

It's a percentage - so 100%

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 3, 2025

cubic-dev-ai bot reviewed Dec 3, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

geemanjs force-pushed the pay-4106-workers-are-not-container-aware branch from d659c15 to 28b62d3 Compare December 4, 2025 21:01

geemanjs requested review from a team and MarcL and removed request for a team December 4, 2025 21:02

konstantintieber reviewed Dec 4, 2025

View reviewed changes

...ontend/editor-ui/src/features/settings/orchestration.ee/components/WorkerChartsAccordion.vue Outdated Show resolved Hide resolved

geemanjs added 4 commits December 5, 2025 10:57

fix: PAY-4106 - Make workers memory constraints more container aware

db7bd59

fix: labels on chart

a42e1bd

fix: linting issues & cubic issue

367e794

fix: linting and comment

974ff66

geemanjs force-pushed the pay-4106-workers-are-not-container-aware branch from 28b62d3 to 974ff66 Compare December 5, 2025 09:57

fix: linting and comment

68c8aab

konstantintieber reviewed Dec 5, 2025

View reviewed changes

geemanjs requested a review from konstantintieber December 5, 2025 14:20

konstantintieber approved these changes Dec 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: PAY-4106 - Make workers memory constraints more container aware #22698

fix: PAY-4106 - Make workers memory constraints more container aware #22698

geemanjs commented Dec 3, 2025 •

edited

Loading

Uh oh!

bundlemon bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Dec 3, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Dec 3, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Dec 3, 2025 •

edited

Loading

Uh oh!

geemanjs Dec 4, 2025

Uh oh!

currents-bot bot commented Dec 4, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

Uh oh!

konstantintieber Dec 5, 2025

Uh oh!

geemanjs Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	newDataMemoryUsage.labels = dataMemoryUsage.value.labels;
	newDataMemoryUsage.labels = newDataJobs.labels;

	newDataCPU.labels = dataCPU.value.labels;
	newDataCPU.labels = newDataJobs.labels;

	{{ memAsGb(worker.process.memory.available) }}Gb /
	{{ memAsGb(worker.process.memory.available) }}GB /

fix: PAY-4106 - Make workers memory constraints more container aware #22698

Are you sure you want to change the base?

fix: PAY-4106 - Make workers memory constraints more container aware #22698

Conversation

geemanjs commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Linear tickets, Github issues, and Community forum

Review / Merge checklist

Uh oh!

bundlemon bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BundleMon

Uh oh!

codecov bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

geemanjs Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

currents-bot bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

konstantintieber Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

geemanjs Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

geemanjs commented Dec 3, 2025 •

edited

Loading

bundlemon bot commented Dec 3, 2025 •

edited

Loading

codecov bot commented Dec 3, 2025 •

edited

Loading

cubic-dev-ai bot Dec 3, 2025 •

edited

Loading

cubic-dev-ai bot Dec 3, 2025 •

edited

Loading

cubic-dev-ai bot Dec 3, 2025 •

edited

Loading

currents-bot bot commented Dec 4, 2025 •

edited

Loading