Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for parsing OPUS2 System Object CSV files. The implementation introduces data model classes, a CSV reader, comprehensive test coverage, and test data files.
- New data model classes (
SystemObject,SystemObjectType) with proper dataclass definitions - CSV reader (
SOReader) supporting both file and string inputs with configurable delimiters - Comprehensive test suite covering basic files, complex values, multiline values, and edge cases
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 22 comments.
Show a summary per file
| File | Description |
|---|---|
| templateprocessor/so.py | Defines data model classes for System Objects using dataclasses |
| templateprocessor/soreader.py | Implements CSV reader for parsing System Object files with semicolon delimiter support |
| tests/test_soreader.py | Provides comprehensive test coverage for SOReader functionality |
| tests/Makefile | Adds test_soreader.py to the test suite |
| data/events.csv | Test data file containing basic event definitions |
| data/parameters.csv | Test data file containing complex parameter values |
| data/housekeeping.csv | Test data file containing multiline housekeeping data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ficzer
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.