Repository navigation
fix: enforce sequence bounds on remote mutable replies - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A remote node can answer a mutable lookup with a correctly signed value whose sequence number does not satisfy
more_recent_than. Previously the client delivered that value and cached it for subscribers to the active lookup.Check the requested sequence bound after validating the value. Only values with a strictly greater sequence number reach subscribers or the active lookup's response cache. Valid older replies still contribute nodes and tokens as before.
Validation: 128 tests pass with
cargo test --locked --all-features --all-targets -- --skip put_get_mutable_real_dht(the skipped test writes to the public DHT). A loopback UDP regression checks no bound, a lower bound, and equal/higher bounds against a responder that ignores the requested sequence. Formatting, diff checks, and Clippy with-D warningspass.