fix(wasm): use n0_future for all time::{Instant, Duration} references #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/194/docs/iroh_blobs/ Last updated: 2025-11-11T15:10:57Z |
Frando
approved these changes
Nov 11, 2025
Frando
reviewed
Nov 11, 2025
| irpc::Error::OneshotRecv { source, .. } => OneshotRecvSnafu.into_error(source), | ||
| irpc::Error::Send { source, .. } => SendSnafu.into_error(source), | ||
| irpc::Error::Request { source, .. } => RequestSnafu.into_error(source), | ||
| #[cfg(feature = "rpc")] |
Member
There was a problem hiding this comment.
it's the reason for the CI fails. We might want to fix this in irpc because it's a bit footgunny: The irpc::Error::Write variant is only present if the rpc feature of irpc is enabled. But for now just leave in the cfg here.
matheus23
reviewed
Nov 12, 2025
| n0-future = "0.3.0" | ||
| n0-snafu = "0.2.2" | ||
| n0-future = "0.3.1" | ||
| n0-snafu = { version = "0.2.2", git="https://github.com/n0-computer/n0-snafu.git", branch="b5/wasm" } |
Member
There was a problem hiding this comment.
Need to remember to replace this with an actual dependency before merging.
4 tasks
Collaborator
|
Replaced by #201 |
rklaehn
added a commit
that referenced
this pull request
Dec 4, 2025
) ## Description While this will currently compile to wasm, when running in the browser, any reference to `std::time` will explode with unsupported platform errors, this fixes that. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions Note: replaces #194 which is obsolete due to the change to n0-error ## Change checklist - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While this will currently compile to wasm, when running in the browser, any reference to
std::timewill explode with unsupported platform errors, this fixes that.Breaking Changes
Notes & open questions
Change checklist