feat: Add back builder for blobs protocol #129
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/129/docs/iroh_blobs/ Last updated: 2025-07-28T08:56:12Z |
Collaborator
Author
|
I was able to remove the endpoint from BlobsProtocol, so I think having just a constructor is actually fine... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We used to have a builder in iroh-blobs. This brings it back. It does not have as many options as the previous one, but there will be more, probably.
I left the BlobsProtocol::new public for now. We can make it private if the options become too many. There will probably be minor changes related to how the provider events work, so people that don't need those are probably best served using the builder.
Breaking Changes
None
Notes & open questions
Make new private right now?
Note: I somewhat dislike the BlobsProtocol::memory().build() style compared to explicitly creating a store, since it often means that you do preliminary work like importing data while the blobs protocol is already listening. But YMMV.
Change checklist