[#159] WAL 로그 저장 포맷 선택 및 구현 #169
Conversation
Pull reviewers statsStats of the last 14 days for rrdb:
|
|
✅ Total Coverage: 55.06% |
|
✅ Total Coverage: 54.64% |
|
✅ Total Coverage: 54.95% |
|
✅ Total Coverage: 54.64% |
|
✅ Total Coverage: 54.67% |
| wal_enabled = true | ||
| wal_directory = "/var/lib/rrdb/wal" | ||
| wal_segment_size = 16777216 | ||
| wal_extension = "log" |
There was a problem hiding this comment.
TODO: 추후에는 yaml 이든, 자체 포맷 구현이든 포맷 하나 골라서 구조체 형태로 기본값 정의하기
|
✅ Total Coverage: 54.56% |
|
✅ Total Coverage: 54.48% |
|
✅ Total Coverage: 54.47% |
|
✅ Total Coverage: 54.15% |
|
✅ Total Coverage: 55.14% |
|
✅ Total Coverage: 54.81% |
|
✅ Total Coverage: 54.81% |
|
단순히 초기에 값을 불러오는 것을 넘어서, |
| pub entry_type: EntryType, | ||
| pub data: Option<Vec<u8>>, | ||
| pub timestamp: u128, | ||
| pub transaction_id: Option<u64>, |
There was a problem hiding this comment.
네 우선은 그렇게 생각중이에요. 추후 변동 가능
| where | ||
| T: WALEncoder<Vec<WALEntry>>, | ||
| { | ||
| /// The sequence number of the WAL file |
There was a problem hiding this comment.
네 주석 싹 다 한국어로 바꿔놓을게요
| let last_entry = match saved_entries.last() { | ||
| Some(entry) => entry, | ||
| None => return Ok((max_sequence + 1, Vec::new())), | ||
| }; |
There was a problem hiding this comment.
이건 어떤가요
let Some(last_entry) = saved_entries.last() else {
return Ok((max_sequence + 1, Vec::new()))
};호불호 갈릴 수 있긴 한데
There was a problem hiding this comment.
좋은 것 같습니다. 한번도 안 써봤던 문법이네요
resolves: #159
WAL