[ISSUE #10607]🐛Client runtime ownership tests expect internal error text in public

[WaterWhisperer]

Which Issue(s) This PR Fixes(Closes)

• Fixes [Bug🐛] Client runtime ownership tests expect internal error text in public #10607

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

• Tests
  • Improved validation of client ownership conflict errors.
  • Improved validation of shutdown-related admission errors.
  • Tests now verify standardized error codes and exact compatibility error messages.

[rocketmq-rust-bot]

🔊@WaterWhisperer 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 5d603f03-f2b8-4aaa-9279-037e99d73c2e

📥 Commits

Reviewing files that changed from the base of the PR and between e698128 and 80e478d.

📒 Files selected for processing (1)

• rocketmq-client/tests/client_runtime_ownership.rs

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

Walkthrough

The ownership tests now validate CORE_ARGUMENT_INVALID and exact MQClientException::error_message() values for client-id conflicts and shutdown admission. Production error mapping remains unchanged.

Changes

Client runtime ownership test assertions

Layer / File(s)	Summary
Structured error assertions rocketmq-client/tests/client_runtime_ownership.rs	The tests import MQClientException and verify the canonical error code plus exact retained messages for client-id conflicts and shutdown admission.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other · Severity of issue fixed: Low

Suggested reviewers: mxsm

Merge Risk: ⚪ Minimal · up to 80e47

This test-only change improves validation without altering production behavior or introducing merge-blocking risk.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the affected client runtime ownership tests and the error-text expectation issue addressed by the changes.
Linked Issues check	✅ Passed	The change satisfies issue #10607. It updates the two existing assertions in rocketmq-client/tests/client_runtime_ownership.rs. Each rejection checks CORE_ARGUMENT_INVALID with error.is(...) and…
Out of Scope Changes check	✅ Passed	The diff is limited to the required test file. It adds the MQClientException import and replaces the two outdated string assertions. No production mapping or unrelated behavior changes are present.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks each error twice
The code is clear, the text is precise
Conflict and shutdown now align
With messages kept in proper line
Tests hop onward, bright and nice}

_{Comment @coderabbitai help to get the list of available commands.}