fix: apply PR #17 improvements with correct Rust toolchain version (1.85 → 1.86)#19
Draft
Copilot wants to merge 1 commit into
Draft
fix: apply PR #17 improvements with correct Rust toolchain version (1.85 → 1.86)#19Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
…copilot-review-instructions Agent-Logs-Url: https://github.com/mwallner/mergetopus/sessions/97054294-dd96-4aac-b561-7c510fad2be6 Co-authored-by: mwallner <5354972+mwallner@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mwallner
May 13, 2026 05:08
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR incorporates all the improvements from PR #17 while fixing the compilation error that caused CI to fail, and adds a Copilot reviewer instructions file.
Root Cause of PR #17 Failure
PR #17 added
rust-toolchain.tomlpinning Rust to1.85, butcargo-bundle-licenses v4.2.0pulls in:cargo-platform@0.3.1— requires rustc ≥ 1.86cargo_metadata@0.23.0— requires rustc ≥ 1.86This caused the CI step
cargo install --locked cargo-bundle-licensesto fail with:Changes
rust-toolchain.toml1.86instead of1.85(fixes the compilation failure)src/planner.rsas_deref().unwrap_or()instead of.clone().unwrap_or_else()to avoid unnecessary heap allocation.github/workflows/build-linux.ymldtolnay/rust-toolchain@stable+Swatinem/rust-cache@v2steps.github/workflows/build-windows.ymlcargo teststep (already covered byInvoke-Build Build,Test).gitignore.DS_Storefor macOS contributors.github/copilot-review-instructions.mdCopilot Reviewer Instructions
Added
.github/copilot-review-instructions.mdwith the following key instruction:This would have caught the PR #17 failure automatically.